Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin) kubenetes api #5026

Closed
wants to merge 4 commits into from
Closed

fix(plugin) kubenetes api #5026

wants to merge 4 commits into from

Conversation

Tpo76
Copy link
Contributor

@Tpo76 Tpo76 commented May 14, 2024

Fix unrelevant path on latest k8s version for cronjob api and ingresses api

/usr/lib/centreon/plugins//centreon_kubernetes_api.pl --plugin=cloud::kubernetes::plugin --mode=list-ingresses --custommode='api' --hostname=172.16.5.223 --port='6443' --proto='https' --token='***' --config-file='' --proxyurl='' --namespace='default' --timeout='10'
List ingresses: 
[uid: 80b37c13-dea7-42cb-bb5d-e49cf0765d5c] [name: apache-ingress] [namespace: default]

/usr/lib/centreon/plugins//centreon_kubernetes_api.pl --plugin=cloud::kubernetes::plugin --mode=cronjob-status --custommode='api' --hostname=172.16.5.223 --port='6443' --proto='https' --token='***' --config-file='' --proxyurl='' --namespace='default' --timeout='10' --ssl-opt="SSL_verify_mode => SSL_VERIFY_NONE" --filter-name='.*' --filter-namespace='.*' --warning-status='' --critical-status='' --verbose 
OK: All CronJobs status are ok

CTOR-713

@Tpo76 Tpo76 requested a review from a team as a code owner May 14, 2024 14:34
@Tpo76 Tpo76 requested a review from Evan-Adam May 14, 2024 14:34
@Tpo76 Tpo76 requested a review from a team as a code owner May 14, 2024 15:01
@Evan-Adam
Copy link
Contributor

do you know what kube version you client have and since which this path became unrevelent ?
we can't change the api we use if other client have an older version still active, that would force them to update.

@Tpo76
Copy link
Contributor Author

Tpo76 commented May 16, 2024

Client version is

Client Version: v1.30.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.0

No idea when it got officially release

Evan-Adam
Evan-Adam previously approved these changes May 17, 2024
Copy link
Contributor

@Evan-Adam Evan-Adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kubernetes.io/blog/2021/04/09/kubernetes-release-1.21-cronjob-ga/
cronjob passed ga in 2021 (version 1.21) which is unsupported since 2022)
https://kubernetes.io/fr/releases/

@garnier-quentin
Copy link
Contributor

You need an option to override the path and be backward compatible

@lucie-dubrunfaut
Copy link
Contributor

Fixed with #5109 taking account of Quentin's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants