Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for headsetcontrol v3 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Psykar
Copy link

@Psykar Psykar commented Apr 30, 2024

Removes deprecated silent cli arg and uses json parsing instead.

@Psykar
Copy link
Author

Psykar commented Apr 30, 2024

If we don't want to go this far, then we should at least hide the deprecated argument text which is spamming my logs atm :D

See https://github.com/Sapd/HeadsetControl/releases/tag/3.0.0 for context

Removes deprecated cli arg and uses json parsing instead.
@izzy
Copy link

izzy commented Jul 1, 2024

Idk if that's a common theme with other headsets but at least with my Corsaid Void showing the bat% instead of just Chg makes no sense and percentage should probably be hidden because the percentage is (likely) measure via voltage at output, which during charging can easily go up to 99% despite the actual battery being something like 3%.

I just checked and the software in windows does the same - it will never show percentage during charging, only once the charger is unplugged will it report the percentage again.

This worked before where when charging it would not show percentage, only Chg, so that would be regression and likely to be perceived as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants