-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analyser: reworked the analysis of a model with external variables #1077
Merged
Commits on Dec 12, 2022
-
Analyser: simplified our code.
By decrementing things wherever possible, which makes the code easier to read and, therefore, to update/maintain.
Configuration menu - View commit details
-
Copy full SHA for 014e5e7 - Browse repository at this point
Copy the full SHA 014e5e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 410c272 - Browse repository at this point
Copy the full SHA 410c272View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c79b1b - Browse repository at this point
Copy the full SHA 7c79b1bView commit details
Commits on Dec 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fe1458a - Browse repository at this point
Copy the full SHA fe1458aView commit details
Commits on Dec 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ccc3912 - Browse repository at this point
Copy the full SHA ccc3912View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b8fc8b - Browse repository at this point
Copy the full SHA 9b8fc8bView commit details -
Analyser: handle external variables as soon as possible.
We used to do handle them after having analysed the model which meant having to requalify a variable-based constant equation as an algebraic equation if it depended on one or several external variables. In other words, as a developer, we had to think about what consequence(s) an external variable might have on our analysed model. Until now, it wasn't too much a problem, but with our wish to support systems of non-linear algebraic equations (and then DAEs), this is going to become a nightmare.
Configuration menu - View commit details
-
Copy full SHA for 7710cad - Browse repository at this point
Copy the full SHA 7710cadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 840cd88 - Browse repository at this point
Copy the full SHA 840cd88View commit details -
Configuration menu - View commit details
-
Copy full SHA for b158dcf - Browse repository at this point
Copy the full SHA b158dcfView commit details -
Analyser: no need to test for errors here.
... since we may have only generated warnings.
Configuration menu - View commit details
-
Copy full SHA for 0df2a97 - Browse repository at this point
Copy the full SHA 0df2a97View commit details -
GCov: trying to get 100% coverage with GCov.
With: ``` mDependencies.erase(std::remove_if(mDependencies.begin(), mDependencies.end(), [=](const auto &dependency) -> bool { return dependency.lock()->variable() == nullptr; }), ``` it reports that the first line is not covered...!?
Configuration menu - View commit details
-
Copy full SHA for 8763158 - Browse repository at this point
Copy the full SHA 8763158View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18788f2 - Browse repository at this point
Copy the full SHA 18788f2View commit details -
GCov: trying to get 100% coverage with GCov.
Even with: ``` mDependencies.erase(std::remove_if(mDependencies.begin(), mDependencies.end(), [=](const auto &dependency) -> bool { return dependency.lock()->variable() == nullptr; }), mDependencies.end()); ``` GCov reports that the first line is not covered...!? So, we now put everything on stupidly long line!
Configuration menu - View commit details
-
Copy full SHA for e1a4fbd - Browse repository at this point
Copy the full SHA e1a4fbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for eea3611 - Browse repository at this point
Copy the full SHA eea3611View commit details
Commits on Jan 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e54a976 - Browse repository at this point
Copy the full SHA e54a976View commit details
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 10d7529 - Browse repository at this point
Copy the full SHA 10d7529View commit details
Commits on Jan 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4e740d5 - Browse repository at this point
Copy the full SHA 4e740d5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.