Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyser: reworked the analysis of a model with external variables #1077

Merged
merged 17 commits into from
Jan 27, 2023

Commits on Dec 12, 2022

  1. Analyser: simplified our code.

    By decrementing things wherever possible, which makes the code easier to read and, therefore, to update/maintain.
    agarny committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    014e5e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    410c272 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c79b1b View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Configuration menu
    Copy the full SHA
    fe1458a View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Some minor cleaning up.

    agarny committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    ccc3912 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b8fc8b View commit details
    Browse the repository at this point in the history
  3. Analyser: handle external variables as soon as possible.

    We used to do handle them after having analysed the model which meant having to requalify a variable-based constant equation as an algebraic equation if it depended on one or several external variables. In other words, as a developer, we had to think about what consequence(s) an external variable might have on our analysed model. Until now, it wasn't too much a problem, but with our wish to support systems of non-linear algebraic equations (and then DAEs), this is going to become a nightmare.
    agarny committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    7710cad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    840cd88 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b158dcf View commit details
    Browse the repository at this point in the history
  6. Analyser: no need to test for errors here.

    ... since we may have only generated warnings.
    agarny committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0df2a97 View commit details
    Browse the repository at this point in the history
  7. GCov: trying to get 100% coverage with GCov.

    With:
    ```
    mDependencies.erase(std::remove_if(mDependencies.begin(), mDependencies.end(),
                                       [=](const auto &dependency) -> bool {
                                           return dependency.lock()->variable() == nullptr;
                                       }),
    ```
    it reports that the first line is not covered...!?
    agarny committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8763158 View commit details
    Browse the repository at this point in the history
  8. Slight change to a comment.

    agarny committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    18788f2 View commit details
    Browse the repository at this point in the history
  9. GCov: trying to get 100% coverage with GCov.

    Even with:
    ```
    mDependencies.erase(std::remove_if(mDependencies.begin(), mDependencies.end(), [=](const auto &dependency) -> bool {
                            return dependency.lock()->variable() == nullptr;
                        }),
                        mDependencies.end());
    ```
    GCov reports that the first line is not covered...!? So, we now put everything on stupidly long line!
    agarny committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e1a4fbd View commit details
    Browse the repository at this point in the history
  10. Some minor cleaning up.

    agarny committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    eea3611 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Some minor cleaning up.

    agarny committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e54a976 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    10d7529 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Configuration menu
    Copy the full SHA
    4e740d5 View commit details
    Browse the repository at this point in the history