update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #72 Is this information available in docs?
* remove unused import statements * remove unused variable and arguments
With flush, log info can appear immediately when it is directed to a pipe or file.
* commandline backwards compatible fix for models.py * changes formatting to accomodate a 120 char width
The batch size for the training set was erroneously used for instantiating the DataLoader class for the test set.
Closes #204
As is the final network output is modulated with a tanh nonlinearity. This is undesirable. As a simple / realistic fix we add a final linear layer.
* Fix indentation to be self-consistent Replace 2-space with 4-space indentation * Fix indentation to be self-consistent Replace 2-space with 4-space indentation * Fix indentation Replace 3-space indentation with 4-space indentation
* Fix UserWarning This fixes the following warning in mnist/main.py src/torch_mnist.py:68: UserWarning: Implicit dimension choice for log_softmax has been deprecated. Change the call to include dim=X as an argument. Performance is unaffected. * Fix UserWarning in mnist_hogwild In this case, dim=1 because the input tensor x has ndim=2. See _get_softmax_dim in https://github.com/pytorch/pytorch/blob/master/torch/nn/functional.py
* smooth_l1_loss now requires shapes to match * once scalars are enabled we must torch.stack() instead of torch.cat() a list of scalars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.