Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README with latest browser release notes #51

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

ssuttner
Copy link
Member

@ssuttner ssuttner commented Jun 6, 2018

Given the fact that Chrome 67 is now released, I updated the README.
I think this reads a little bit better :)

Copy link
Contributor

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Left one minor comment.

README.md Outdated
- Google Chrome 65+ (Disabled by default, go to chrome:https://flags to enable Web Authentication API feature). Note: it is enabled by default in 67+ as stated [here](https://www.chromestatus.com/feature/5669923372138496).
- Mozilla Firefox Quantum 60+ ([Enabled by default](https://www.mozilla.org/en-US/firefox/60.0/releasenotes/))
- Google Chrome 67+ ([Enabled by default](https://www.chromestatus.com/feature/5669923372138496))
- Google Chrome 65+ (Disabled by default, go to chrome:https://flags to enable Web Authentication API feature)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about changing 65+ to 65 & 66, to avoid any potential confusion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! I'll update. Thanks for catching that.

@grzuy
Copy link
Contributor

grzuy commented Jun 6, 2018

Awesome, thanks!

@grzuy grzuy merged commit de42f42 into master Jun 6, 2018
@grzuy grzuy deleted the docs_readme_browsers branch June 6, 2018 17:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants