feat: Apple App Attestation proof-of-concept. #385
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're looking into using this gem with Apple App attestation support, so I implemented the
app-appattest
format. This is just a proof-of-concept code, we haven't tested it end-to-end, only manually.The format and its validations are described here.
I would love to hear your feedback on this and also your opinion on two aspects that I had to deal with:
However there is no way to distinguish between development and production environment -- I added a new configuration to the
RelyingParty
class for that.At this point in the class we have no access to the key identifier, so I have no idea how to support it -- any ideas?
Let me know your thoughts, thanks!