Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing support for backup_eligibility and backup_state #384

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Testing support for backup_eligibility and backup_state #384

merged 1 commit into from
Feb 3, 2023

Conversation

hagould
Copy link
Contributor

@hagould hagould commented Feb 2, 2023

Adds backup bits to WebAuthn::FakeClient.create and get for testing.

santiagorodriguez96
santiagorodriguez96 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!! Thank you! ❤️

@hagould
Copy link
Contributor Author

hagould commented Feb 2, 2023

Thanks! I don't have the write access to merge, but this is otherwise good to go 👍

@santiagorodriguez96 santiagorodriguez96 merged commit 70282e3 into cedarcode:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santiagorodriguez96 santiagorodriguez96 santiagorodriguez96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hagould @santiagorodriguez96