-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for OpenSSL 3 compatibility #360
Conversation
Thank you for raising this, I am also keen on OpenSSL 3 support 🙂 |
@ClearlyClaire I am unsure why the additional changes are required. All tests pass with PR: #361 Have I missed something really important? |
If I remember correctly, the code will run just fine with no deprecation notice on the |
I understand. I will close my PR and will upvote yours. Thank you! |
Is your work backwards compatible with |
I ran tests with OpenSSL 1.1 and had no issue. |
@ClearlyClaire thanks for your work any news about this? |
@ClearlyClaire sorry for the delay. If you can update the dependencies and add openssl 3 to Appraisal we can get this in shortly. Thanks! |
This gems does not seem to be using Appraisal, it does not come with a |
You're right. There's no appraisal here. I was thinking about the conformance tests when I wrote that. I won't block this on that tho, we can fix bump conformance tests to latest version in a separate issue/PR. I just release |
Seems like |
Pushed a commit changing use of |
Is there anything blocking a merge? |
This is not enough for OpenSSL 3 compatibility as various dependencies still need fixing, but as far as I know, it should fix all incompatible code from the
webauthn-ruby
gem itself without breaking compatibility with the 2.2 version of theopenssl
gem.Actual compatibility with OpenSSL 3 would require at least the following to be merged: