Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Apple App Attest root certificate #349

Closed
wants to merge 1 commit into from
Closed

Update Apple App Attest root certificate #349

wants to merge 1 commit into from

Conversation

Ilushkanama
Copy link

Fixes #348

@Ilushkanama Ilushkanama mentioned this pull request Oct 7, 2021
Closed
@dmoss18
Copy link

dmoss18 commented Oct 12, 2021

Just FYI, this will break WebAuthn. Apple has a different certificate for App attest, and this gem doesn't currently support that format.

To fix, you would need to do something like subclass WebAuthn::AttestationStatement::Apple with the above certificate and then add the class here with the key "apple-appattest".

@santiagorodriguez96
Copy link
Contributor

Closing this as #348 was closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix outdated Apple App Attest root certificate
3 participants
@Ilushkanama @dmoss18 @santiagorodriguez96