ci: switch to GitHub Actions #341
Conversation
| appraise "cose_head" do | ||
| gem "cose", git: "https://github.com/cedarcode/cose-ruby" | ||
| end | ||
|
|
||
| appraise "openssl_head" do | ||
| gem "openssl", git: "https://github.com/ruby/openssl" | ||
| end |
There was a problem hiding this comment.
I know this were allowed to fail before, but isn't it necessary to still test them anyway on .github/workflows/build.yml?
There was a problem hiding this comment.
Ideally we would want to keep them, but GitHub Actions don't support something like TravisCI allow_failures setting. People asking for it in https://github.com/actions/toolkit/issues/399.
While it's somewhat useful to test against the head of this dependencies and see whether there's an upcoming incompatibility I don't see it as crucial. So that's the reason still moving to GitHub Actions despite not having that nice-to-have feature.
| - '2.6' | ||
| - '2.5' | ||
| - '2.4' | ||
| - truffleruby |
There was a problem hiding this comment.
Can this test be set to allow failure like it was with Travis CI?
There was a problem hiding this comment.
As I mentioned in the previous comment we don't have something like that.
That said, also note that before we were testing (and allowing failure) against truffleruby-head. Now my intention is to test against truffleruby (stable truffleruby) and require it passes.
The concern and reason why I didn't consider TruffleRuby to be one of the required rubies before was because it takes a significant higher amount of time to run agasint TruffleRuby than CRuby, which made the TravisCI run take a lot of time to finish. Now I'm seeing that GitHub Actions takes in total way way less time to finish (it's faster), so including TruffleRuby (while still taking more time than CRuby) it doesn't increase to total time by a lot so it's reasonable.
There was a problem hiding this comment.
Great! Didn't notice that difference between truffleruby and truffleruby-head. Good to know!
No description provided.