Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action to prevent merging of fixup commits #330

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

santiagorodriguez96
Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 commented Jul 30, 2020

Fixup commits are OK in pull requests, but without a check like this one though, it's easy to forget to squash them away before merging to master.

See https://thoughtbot.com/blog/autosquashing-git-commits

Followed this guide: https://github.com/marketplace/actions/block-fixup-commit-merge

@santiagorodriguez96 santiagorodriguez96 force-pushed the add-check-for-preventing-fixups-commits branch from 46b7929 to b56d1c0 Compare July 30, 2020 15:56
Copy link
Contributor

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@santiagorodriguez96 santiagorodriguez96 changed the title Add Github action for prevent merging of fixup commits Add Github action to prevent merging of fixup commits Jun 17, 2021
@santiagorodriguez96 santiagorodriguez96 force-pushed the add-check-for-preventing-fixups-commits branch from 1b85e25 to 03050cf Compare June 17, 2021 18:12
@brauliomartinezlm brauliomartinezlm merged commit 3d25ba7 into master Jun 20, 2021
@brauliomartinezlm brauliomartinezlm deleted the add-check-for-preventing-fixups-commits branch June 20, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants