Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for extensions #323

Merged
merged 6 commits into from
Jun 27, 2020

Conversation

santiagorodriguez96
Copy link
Contributor

Why

After merging #317, we should update the docs for specifying how to get the extensions.

README.md Outdated
webauthn_credential.authenticator_extension_outputs #=> nil
```

The list of all current implemented extensions can be found [here](https://w3c.github.io/webauthn/#sctn-defined-extensions).
Copy link
Contributor Author

@santiagorodriguez96 santiagorodriguez96 Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I added the link to the editor’s draft documentation, which is different from the one that we are using in this file. That is because the editor's draft contains the updated list of extensions currently implemented after a lot were removed from the spec in w3c/webauthn#1386.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.

I updated so that we link to the two lists, the "last published" and the "draft" one.

Copy link
Contributor

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you.

Pushed a few minor updates here.

@grzuy grzuy merged commit f8c6302 into master Jun 27, 2020
@grzuy grzuy deleted the add-documentation-for-extensions branch June 27, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants