fix: AttestationStatement::TPM#valid? blowing up when using libssl 1.0.2 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagorodriguez96
force-pushed
the
fix_tpm_attestation_statement_valid
branch
from
9332be0
to
5c0f206
Compare
grzuy
reviewed
May 30, 2020
.travis.yml
Outdated
| - gemfile: gemfiles/cose_head.gemfile | ||
| - gemfile: gemfiles/openssl_head.gemfile | ||
|
|
||
| before_install: | ||
| - ./install-openssl.sh | ||
| - ./install-ruby.sh |
There was a problem hiding this comment.
Can we put these inside a script/ci/ folder?
There was a problem hiding this comment.
There was a problem hiding this comment.
Sure! I would like to keep both files though, in order to be explicit of what's being installed without having to find the script and open it to see what it's being done.
What do you think?
santiagorodriguez96
force-pushed
the
fix_tpm_attestation_statement_valid
branch
from
afc6fd8
to
e83a3e8
Compare
grzuy
approved these changes
Jun 3, 2020
.travis.yml
Outdated
| - gemfile: gemfiles/cose_head.gemfile | ||
| - gemfile: gemfiles/openssl_head.gemfile | ||
|
|
||
| before_install: | ||
| - ./script/ci/install-openssl.sh | ||
| - ./script/ci/install-ruby.sh |
There was a problem hiding this comment.
Can we remove the extension?
Not needed and not standard to use it.
santiagorodriguez96
force-pushed
the
fix_tpm_attestation_statement_valid
branch
from
e83a3e8
to
2e01e6a
Compare
The build is failing when using libssl v1.0.2 and we haven't noticed until now since we aren't testing against that version in Travis. In order to fix compatibility these issues with OpenSSL 1.0 we have to update the gem tpm-key_attestation which is the one that it was failing.
santiagorodriguez96
force-pushed
the
fix_tpm_attestation_statement_valid
branch
from
5803693
to
6d2c708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
AttestationStatement::TPM#valid?is blowing up when using libssl v1.0.2.The error was inside TPM Key Attestation – see cedarcode/tpm-key_attestation#5 – so we must update that dependency.
Steps Taken
References