feat: verify credential public key algorithm #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauliomartinezlm
approved these changes
Feb 6, 2020
| @@ -62,7 +62,7 @@ def length | |||
| def valid_credential_public_key? | |||
| cose_key = COSE::Key.deserialize(public_key) | |||
|
|
|||
| !!cose_key.alg | |||
| !!cose_key.alg && WebAuthn.configuration.algorithms.include?(COSE::Algorithm.find(cose_key.alg).name) | |||
There was a problem hiding this comment.
I've tried removing the right side of the && and none of the existing test fail (nor the ones you had to add the algorightm to the configuration). Do you think it would be worth to write a test that fails in case the algorithm used in the key is not among the ones configured?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #275