Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix conformance tests after subject alt name validation #292

Closed
wants to merge 1 commit into from
Closed

test: fix conformance tests after subject alt name validation #292

wants to merge 1 commit into from

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Dec 24, 2019

@grzuy grzuy mentioned this pull request Dec 24, 2019
Merged
bdewater
bdewater approved these changes Dec 24, 2019
View reviewed changes
Copy link
Collaborator

@bdewater bdewater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is pretty much the same what I did in ffbd683

Filed an issue upstream about it: fido-alliance/conformance-test-tools-resources#537

@grzuy
Copy link
Contributor Author

grzuy commented Dec 24, 2019

Yep, this is pretty much the same what I did in ffbd683

Oh, right.
Didn't remember that commit.

Filed an issue upstream about it: fido-alliance/conformance-tools-issues#537

Great, thank you!

@grzuy
Copy link
Contributor Author

grzuy commented Dec 26, 2019

Cherry-picked part of that commit in #293 .

Closing this one in favor of that one.

@grzuy grzuy closed this Dec 26, 2019
@grzuy grzuy deleted the fix_tpm_conformance branch December 26, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdewater bdewater bdewater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grzuy @bdewater