Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: can validate fido-u2f attestation #16

Merged
merged 5 commits into from
May 24, 2018

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented May 23, 2018

To do:

  • fix rubocop
  • rename x and y
  • memoize when necessary
  • fix merge conflicts

Copy link
Member

@brauliomartinezlm brauliomartinezlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed changes. Looks pretty awesome 🍺 .
Only comments were about x and y methods, but saw them in your checklist.

I also wondered around for a while around how to make AuthenticatorData handle data structure a bit niftier but couldn't quickly come up with something better to avoid the constant usage to name lengths and positions.

@grzuy
Copy link
Contributor Author

grzuy commented May 24, 2018

Haha, yes. AuthenticatorData a bit tricky. Something to keep in mind for the future, if we find a better way to handle that.

@grzuy grzuy force-pushed the attestation_statement_fido_u2f branch from 62e4a88 to 08083dd Compare May 24, 2018 15:41
@grzuy grzuy merged commit 1332caf into master May 24, 2018
@grzuy grzuy deleted the attestation_statement_fido_u2f branch May 24, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants