feat: add client data origin validation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
approved these changes
May 24, 2018
| }.to raise_exception(RuntimeError, "Missing client_data_json") | ||
| end | ||
|
|
||
| describe "origin validation" do | ||
| let(:base_url) { "http:https://localhost" } |
There was a problem hiding this comment.
What about calling this original_origin instead of base_url? Feel like it might help understandability.
|
|
||
| describe "origin validation" do | ||
| let(:base_url) { "http:https://localhost" } | ||
| let(:challenge) { Base64.urlsafe_encode64(SecureRandom.random_bytes(16)) } |
There was a problem hiding this comment.
Same reasoning here, original_challenge instead of challenge?
|
|
||
| def hash_to_encoded_cbor(hash) | ||
| Base64.urlsafe_encode64(CBOR.encode(hash)) | ||
| end |
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
There's already a .rubocop.yml in place with just a few cops enabled, very minimal. The goal was to keep some kind of consistency from the start.
Do you mind checking if bundle exec rubocop is green for this branch? If you have an opinion about changing any of the enabled cops let me know :-)
There was a problem hiding this comment.
Didn't know about it :). Will address!
|
@grzuy comments addressed. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.