Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: don't confuse by telling that the attested public key is al… #128

Merged
merged 1 commit into from
Mar 11, 2019
Merged

refactor: don't confuse by telling that the attested public key is al… #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: don't confuse by telling that the attested public key is al… 
…ways for a U2F attestation
  • Loading branch information
@grzuy
grzuy committed Mar 11, 2019
commit 625324356fe7361d89b38abe233daff2bf6c7ee2
4 changes: 2 additions & 2 deletions lib/webauthn/authenticator_data/attested_credential_data.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

require "webauthn/authenticator_data/attested_credential_data/public_key_u2f"
require "webauthn/authenticator_data/attested_credential_data/public_key"

module WebAuthn
class AuthenticatorData
Expand Down Expand Up @@ -57,7 +57,7 @@ def id
end

def public_key
@public_key ||= PublicKeyU2f.new(data_at(public_key_position, public_key_length))
@public_key ||= PublicKey.new(data_at(public_key_position, public_key_length))
end

def id_position
Expand Down
2 changes: 1 addition & 1 deletion ...ttested_credential_data/public_key_u2f.rb → ...ta/attested_credential_data/public_key.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
module WebAuthn
class AuthenticatorData
class AttestedCredentialData
class PublicKeyU2f
class PublicKey
COORDINATE_LENGTH = 32

def initialize(data)
Expand Down