Expose AAGUID and use it for packed basic attestation #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
commented
Mar 11, 2019
| @@ -7,6 +7,8 @@ module AttestationStatement | |||
| class Base | |||
| class NotSupportedError < Error; end | |||
|
|
|||
| AAGUID_EXTENSION_OID = "1.3.6.1.4.1.45724.1.1.4" | |||
There was a problem hiding this comment.
Putting this here since TPM attestation (which I plan to work on in the next few weeks) needs this too.
grzuy
reviewed
Mar 11, 2019
| end | ||
| end | ||
|
|
||
| context "when packed attestation (basic attestation)" do |
There was a problem hiding this comment.
Thank you for moving this test case here, makes sense!
|
Addressed your comments, please have another look @grzuy |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we missed a step from the spec for verifying packed attestation:
I needed to change the tests from #81 to have an attestation certificate with the AAGUID extension and real
authenticator_data.We'll also need the AAGUID for lookup in the Metadata Service (see #66).