feat: add #verify method which raises meaningful errors #116

grzuy · 2019-01-17T22:27:43Z

closes #65

lib/webauthn/authenticator_assertion_response.rb

lib/webauthn/authenticator_data.rb

lib/webauthn/authenticator_response.rb

…sing #verify

…erified

brauliomartinezlm

This looks great @grzuy !!! Thank you so much 🍻

Left you some comments with some feedback. No blockers tho.

spec/webauthn/authenticator_attestation_response_spec.rb

lib/webauthn/authenticator_attestation_response.rb

spec/webauthn/authenticator_attestation_response_spec.rb

lib/webauthn/authenticator_response.rb

Also less prone to errors due to someone changing/adding verification step and returning false instead of raising

…ication and raising

brauliomartinezlm · 2019-01-21T18:59:57Z

lib/webauthn/authenticator_assertion_response.rb

+ def valid?(*args)
+ super
+ rescue WebAuthn::VerificationError
+ false


Isn't this one already implemented in the parent class? @grzuy

feat: add #verify method which raises meaningful errors

7000c2c

grzuy commented Jan 17, 2019

View reviewed changes

lib/webauthn/authenticator_assertion_response.rb Outdated Show resolved Hide resolved

lib/webauthn/authenticator_data.rb Outdated Show resolved Hide resolved

lib/webauthn/authenticator_response.rb Outdated Show resolved Hide resolved

grzuy added 3 commits January 18, 2019 17:06

feat: Don't confuse user by raising something called Invalid.. when u…

ebee614

…sing #verify

refactor: remove unnecessary require

1db5b43

feat: properly inform the user when Authenticator Data could not be v…

e0ea5a0

…erified

brauliomartinezlm approved these changes Jan 21, 2019

View reviewed changes

spec/webauthn/authenticator_attestation_response_spec.rb Outdated Show resolved Hide resolved

lib/webauthn/authenticator_attestation_response.rb Show resolved Hide resolved

grzuy commented Jan 21, 2019

View reviewed changes

spec/webauthn/authenticator_attestation_response_spec.rb Outdated Show resolved Hide resolved

grzuy added 3 commits January 21, 2019 13:57

test: make verification test use #verify instead of #valid?

88ffe80

test: add missing verification test cases

68249ae

test: use #be_truthy to keep consistency

b29e851

grzuy commented Jan 21, 2019

View reviewed changes

lib/webauthn/authenticator_response.rb Outdated Show resolved Hide resolved

grzuy added 3 commits January 21, 2019 15:06

refactor: avoid repetition of raise

2d80750

Also less prone to errors due to someone changing/adding verification step and returning false instead of raising

refactor: remove dead code

ba99552

refactor: remove unnecessary boolean expression after change to verif…

017a95c

…ication and raising

grzuy merged commit 77c5cc8 into master Jan 21, 2019

grzuy deleted the verify_and_raise branch January 21, 2019 18:52

brauliomartinezlm reviewed Jan 21, 2019

View reviewed changes

grzuy mentioned this pull request Feb 22, 2019

Handle WebAuthn verification errors cedarcode/webauthn-rails-demo-app#62

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add #verify method which raises meaningful errors #116

feat: add #verify method which raises meaningful errors #116

grzuy commented Jan 17, 2019 •

edited

Loading

brauliomartinezlm left a comment

brauliomartinezlm Jan 21, 2019 •

edited

Loading

grzuy Jan 21, 2019

feat: add #verify method which raises meaningful errors #116

feat: add #verify method which raises meaningful errors #116

Conversation

grzuy commented Jan 17, 2019 • edited Loading

brauliomartinezlm left a comment

Choose a reason for hiding this comment

brauliomartinezlm Jan 21, 2019 • edited Loading

Choose a reason for hiding this comment

grzuy Jan 21, 2019

Choose a reason for hiding this comment

grzuy commented Jan 17, 2019 •

edited

Loading

brauliomartinezlm Jan 21, 2019 •

edited

Loading