Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cedarcode/webauthn-ruby Loading
base: v2.2.1
Choose a base ref
...
head repository: cedarcode/webauthn-ruby Loading
compare: v2.3.0
Choose a head ref
  • 20 commits
  • 21 files changed
  • 7 contributors

Commits on Jun 13, 2020

  1. refactor: remove unnecessary require

    @brauliomartinezlm
    brauliomartinezlm committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    bffba9b View commit details
    Browse the repository at this point in the history

  2. refactor: move assertion necessary signature verification to be a res… 

    …ponsability of WebAuthn::PublicKey
    @brauliomartinezlm
    brauliomartinezlm committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    8aed5f4 View commit details
    Browse the repository at this point in the history

  3. refactor: Remove SignatureVerifier usage from attestation statement v… 

    …alidation
    @brauliomartinezlm
    brauliomartinezlm committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    aa58043 View commit details
    Browse the repository at this point in the history

  4. refactor: remove SignatureVerifier class and its tests

    @brauliomartinezlm
    brauliomartinezlm committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    782d7d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. feat: provide client extensions as an output

    @santiagorodriguez96
    santiagorodriguez96 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    9840b69 View commit details
    Browse the repository at this point in the history

  2. feat: provide authenticator extensions as an output

    @santiagorodriguez96
    santiagorodriguez96 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    d86cbeb View commit details
    Browse the repository at this point in the history

  3. fixup! feat: provide authenticator extensions as an output

    @santiagorodriguez96
    santiagorodriguez96 committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    b62402e View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. fixup! feat: provide client extensions as an output

    @santiagorodriguez96
    santiagorodriguez96 committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    fc9fb1b View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2020

  1. refactor: scope rescue to a cose error

    @brauliomartinezlm
    brauliomartinezlm committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    4e41ee6 View commit details
    Browse the repository at this point in the history

  2. refactor: move exception definition up and removed unused one

    @brauliomartinezlm
    brauliomartinezlm committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    05d0135 View commit details
    Browse the repository at this point in the history

  3. refactor: build default value into the method signature

    @brauliomartinezlm
    brauliomartinezlm committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    5215139 View commit details
    Browse the repository at this point in the history

  4. refactor: raise an exception if public key alg is not among the ones … 

    …supported by COSE
    @brauliomartinezlm
    brauliomartinezlm committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    835cf9e View commit details
    Browse the repository at this point in the history

  5. refactor: avoid overriding cose_algorithm and just override algorithm… 

    … instead
    @brauliomartinezlm
    brauliomartinezlm committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    a229259 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #313 from cedarcode/remove_signature_verifier 

    Remove SignatureVerifier
    @brauliomartinezlm
    brauliomartinezlm committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    a185f4a View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2020

  1. style: ignore vendor directory 

    When bundler installs gems to the vendor directory, rubocop by picks up their configuration and tries to lint these files as well, leading to false positives.
    @bdewater
    bdewater committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    426362b View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Merge pull request #321 from bdewater/rubocop-ignore-vendor-dir 

    Rubocop: ignore vendor directory
    @bdewater
    bdewater committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    7024468 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #317 from cedarcode/provide_extensions_as_an_outpu… 

    …t_of_the_verification

feat: add API methods for providing received extension information
    @santiagorodriguez96
    santiagorodriguez96 committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1d2f509 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2020

  1. test: update appraisal gem to v2.3

    @grzuy
    grzuy committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    5d71e93 View commit details
    Browse the repository at this point in the history

  2. docs: add documentation for extensions (#323) 

    * docs: add documentation for extensions

Follow up for #317.

* docs: those extensions are defined in the spec - not necessatily implemented by browsers/authenticators

* docs: link to published spec - not editor draft

* docs: key away from Rails specifics in the documentation

* docs: minor grammatic and formatting updates

* docs: provide both extensions list - published and draft

Co-authored-by: Gonzalo <[email protected]>
    @santiagorodriguez96 @grzuy
    santiagorodriguez96 and grzuy committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    f8c6302 View commit details
    Browse the repository at this point in the history

  3. Bump gem version to v2.3.0

    @grzuy
    grzuy committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    924ad13 View commit details
    Browse the repository at this point in the history
Loading