Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importmaps instead of node/webpack #139

Merged
merged 17 commits into from
Dec 22, 2023
Merged

Use importmaps instead of node/webpack #139

merged 17 commits into from
Dec 22, 2023

Conversation

santiagorodriguez96
Copy link
Contributor

Summary

  • Importmaps is the default for new rails apps (webpacker has been retired)
  • This eliminates the need for node in development/prod
  • Simplifies setup a lot

@santiagorodriguez96
build(deps): add importmap-rails
d24f792
@santiagorodriguez96
build(deps): remove webpacker
7cf8a35
@santiagorodriguez96
build: install importmap-rails
08c77a3 
Run `./bin/rails importmap:install`
@santiagorodriguez96
build: add stimulus-rails
372fc51 
* Add the `stimulus-rails` gem to the Gemfile.
* Run `./bin/bundle install`.
* Run `./bin/rails stimulus:install`.
@santiagorodriguez96
build: remove app/javascript/packs/application.js
716dfc4
@santiagorodriguez96
build: import stimulus controllers from importmap
ceb2d41
@santiagorodriguez96
build: pin stub_credentials
82aaaf3
@santiagorodriguez96
build: migrate @rails/ujs to importmap
257f701
@santiagorodriguez96
build: migrate credential.js to importmap
2227d08
@santiagorodriguez96
build: migrate messenger.js to importmaps
63a7e48
@santiagorodriguez96
build: migrate @material components into importmap
c72aac0
@santiagorodriguez96
build: migrate @github/webauthn-json to importmaps
29bc8cd
@santiagorodriguez96
build: migrate sinon to importmaps
339ba06
@santiagorodriguez96
build: migrate turbolinks to importmaps
224b93d
@santiagorodriguez96
chore: remove dummy hello_controller
64d491b
@santiagorodriguez96
chore: remove references to node, yarn and webpack
79b8a5a
@santiagorodriguez96 santiagorodriguez96 force-pushed the sr--use-importmaps branch 2 times, most recently from 705a0ff to 79b8a5a Compare December 15, 2023 21:00
brauliomartinezlm
brauliomartinezlm approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@brauliomartinezlm brauliomartinezlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@santiagorodriguez96
test: fix test failing because sinon was not loaded
885a835 
We were getting a `ReferenceError: require is not defined` error when
loading `sinon` which then resulted in the tests failing with a
`Cannot read properties of undefined (reading 'stub')` error.
@santiagorodriguez96 santiagorodriguez96 merged commit 11630dd into master Dec 22, 2023
1 check passed
@santiagorodriguez96 santiagorodriguez96 deleted the sr--use-importmaps branch December 22, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brauliomartinezlm brauliomartinezlm brauliomartinezlm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@santiagorodriguez96 @brauliomartinezlm