Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persist user only after successful callback #107

Merged
merged 2 commits into from
Oct 7, 2019
Merged

fix: persist user only after successful callback #107

merged 2 commits into from
Oct 7, 2019

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Oct 3, 2019

closes #59

@grzuy grzuy merged commit a3050f2 into master Oct 7, 2019
@grzuy grzuy deleted the persist_user_after_success branch October 7, 2019 16:25
@padulafacundo
Copy link
Contributor

The current_challenge column on User serves no prupose now that the challenge si being stored on session. It can be removed

@grzuy
Copy link
Contributor Author

grzuy commented Oct 8, 2019

True.

Needed to further remove it's usage from other places but still.

@grzuy
Copy link
Contributor Author

grzuy commented Oct 8, 2019

#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padulafacundo padulafacundo padulafacundo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persist user only after registration succeeds
2 participants
@grzuy @padulafacundo