New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist user only after registration succeeds #59

Closed

grzuy opened this issue Oct 23, 2018 · 0 comments · Fixed by #107

Labels

type: error report

Contributor

grzuy commented Oct 23, 2018 •

edited

Loading

[...] In the current registration flow a user is persisted in the create method of the registrations controller. Is it not a good idea to persist the user when the registration succeeds? The challenge could be stored in a session.

Originally posted by @sandergroen in #57 (comment)

grzuy mentioned this issue

Better handle registration/authentication errors #57

Closed

5 tasks

grzuy added the type: error report label

grzuy mentioned this issue

fix: persist user only after successful callback #107

Merged

grzuy closed this as completed in #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment