Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle registration/authentication errors #57

Closed
3 of 5 tasks
grzuy opened this issue Oct 21, 2018 · 2 comments · Fixed by #61
Closed
3 of 5 tasks

Better handle registration/authentication errors #57

grzuy opened this issue Oct 21, 2018 · 2 comments · Fixed by #61

Comments

@grzuy
Copy link
Contributor

grzuy commented Oct 21, 2018

Handle gracefully exception and error conditions in registration/authentication flow and inform the user with clear message so that it can take action to recover from the error and proceed successfully.

Scenarios:

@sandergroen
Copy link
Contributor

@grzuy I addition to the list above. In the current registration flow a user is persisted in the create method of the registrations controller. Is it not a good idea to persist the user when the registration succeeds? The challenge could be stored in a session.

@grzuy
Copy link
Contributor Author

grzuy commented Oct 23, 2018

@grzuy I addition to the list above. In the current registration flow a user is persisted in the create method of the registrations controller. Is it not a good idea to persist the user when the registration succeeds? The challenge could be stored in a session.

Agree.

Created new issue for that #59.

Thanks for bringing that to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants