Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split registration and authentication user flows #53

Closed
grzuy opened this issue Oct 16, 2018 · 7 comments
Closed

Split registration and authentication user flows #53

grzuy opened this issue Oct 16, 2018 · 7 comments
Labels
type: feature request

Comments

@grzuy
Copy link
Contributor

grzuy commented Oct 16, 2018

In hindsight it's quite logical 🤦‍♂️ SessionController does dual duty as both registration and authentication controller, depending on the availability of credentials. I'll open a PR to refactor this a bit since I find it not very intuitive or a good example for somebody's production app.

Originally posted by @bdewater in #33 (comment)
@grzuy grzuy changed the title Split registration from session user flows Split registration from session user flow Oct 16, 2018
@grzuy
Copy link
Contributor Author

grzuy commented Oct 16, 2018

I agree with @bdewater that having Registration with Authentication mixed in the same user flow is confusing from a end-user perspective.

@grzuy grzuy changed the title Split registration from session user flow Split registration from authentication user flow Oct 16, 2018
@grzuy grzuy changed the title Split registration from authentication user flow Split registration and authentication user flows Oct 16, 2018
@grzuy grzuy mentioned this issue Oct 16, 2018
Closed
@grzuy
Copy link
Contributor Author

grzuy commented Oct 17, 2018

@bdewater Are you already in progress with this? If not I can work on it.
I do want to fix this UX confusion sooner than later :-)

Thanks!

@sandergroen
Copy link
Contributor

@grzuy I already did some refactoring locally. I have separated the registration and authentication flows. I can make a pull request if you like.

@grzuy
Copy link
Contributor Author

grzuy commented Oct 19, 2018

@sandergroen Yes, please, pull request would be great, thank you! :-)

@sandergroen sandergroen mentioned this issue Oct 20, 2018
Merged
@bdewater
Copy link
Contributor

Sorry I missed the ping, did not have the time to tackle it myself but happy to see somebody else taking a stab at it :)

grzuy pushed a commit that referenced this issue Oct 22, 2018
@sandergroen @grzuy
Split authentication and registration flow (#56)
10f56b4 
* #53 split authentication and registration flow.

* Code style fixes.

* SCSS styling added.

* Cosmetic changes.

* renamed params method

* Removed unnecessary condition
@grzuy
Copy link
Contributor Author

grzuy commented Oct 22, 2018

@bdewater No worries. Thank you for raising the concern initially!

@grzuy
Copy link
Contributor Author

grzuy commented Oct 22, 2018

Closed by #56

@grzuy grzuy closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grzuy @sandergroen @bdewater