Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add User's username uniqueness validation #2

Merged
merged 1 commit into from
May 7, 2020
Merged

refactor: add User's username uniqueness validation #2

merged 1 commit into from
May 7, 2020

Conversation

santiagorodriguez96
Copy link
Contributor

@santiagorodriguez96 santiagorodriguez96 commented May 6, 2020 •
edited
Loading

No description provided.

@santiagorodriguez96 santiagorodriguez96 added the bug Something isn't working label May 6, 2020
grzuy
grzuy reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Can we also add the unique index for username in the database please?

Thank you!

@santiagorodriguez96
Copy link
Contributor Author

That's already done!

webauthn-2fa-rails-demo/db/schema.rb

Line 20 in 3202118

t.index ["username"], name: "index_users_on_username", unique: true

@santiagorodriguez96 santiagorodriguez96 removed the bug Something isn't working label May 6, 2020
@santiagorodriguez96 santiagorodriguez96 merged commit 21e7cbc into master May 7, 2020
@santiagorodriguez96 santiagorodriguez96 deleted the add-username-uniqueness branch May 7, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzuy grzuy grzuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@santiagorodriguez96 @grzuy