Añadir soporte para previas 'Actividad de instancia aprobada/reprobada' #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagorodriguez96
changed the title
app/models/activity_prerequisite.rb
Outdated
Comment on lines
5
to
9
| if approvable_needed.is_exam? | ||
| approved_approvable_ids.include?(approvable_needed.subject.course.id) | ||
| else | ||
| true | ||
| end |
There was a problem hiding this comment.
q te parece si en vez de chequear que haya pasado el curso (q no necesariamente es requerido para poder dar el examen, por ej en materias que se pueden dar libres), chequeamos que cumpla los pre-requisitos para el approvable_needed?
There was a problem hiding this comment.
Me gusta!
EmilioCristalli
approved these changes
Jun 17, 2024
santiagorodriguez96
deleted the
sr--add-suppor-for-activity-prerequisites
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivación
Hace unos días agregaron a Bedelías la materia
5005 - TUTORIAS ENTRE PARES ACADEMICAS PROGRESA/FINGque tiene una previa particular:Hasta ahora no teníamos ningún caso de este tipo de previas por lo que este PR tiene como objetivo soportarlas.
Detalles
Para esto, agregamos un nuevo tipo de modelo de previas
ActivityPrerequisiteque se cumple en los siguientes casos:(Nótese que por ahora solo hay un caso de este tipo de previa el cual se evalúa sobre un examen)
Adjunto captura de pantalla de cómo se ve este tipo de previa en la app: