Set memory limit on server's docker containers #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/docker-entrypoint
Outdated
| @@ -3,6 +3,11 @@ | |||
| # If running the rails server then create or migrate existing database | |||
| if [ "${1}" == "./bin/rails" ] && [ "${2}" == "server" ]; then | |||
| ./bin/rails db:prepare | |||
|
|
|||
| file="/rails/tmp/pids/server.pid" | |||
There was a problem hiding this comment.
Suggested change
| file="/rails/tmp/pids/server.pid" | |
| file="./tmp/pids/server.pid" |
will this work?
so this file doesn't have to know where the app is running
config/deploy.staging.yml
Outdated
| @@ -8,6 +8,8 @@ servers: | |||
| traefik.http.routers.micarrera_secure-web-staging.rule: Host(`staging.micarrera.uy`) | |||
| traefik.http.routers.micarrera_secure-web-staging.tls: true | |||
| traefik.http.routers.micarrera_secure-web-staging.tls.certresolver: letsencrypt | |||
| options: | |||
| memory: 120MiB | |||
There was a problem hiding this comment.
is this going to be enough?
There was a problem hiding this comment.
Good catch! Increased it to 250MiB 🙂
EmilioCristalli
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were running into issues where the docker containers were increasing the memory usage over time until after a couple of days taking too much memory from the server which causes the server to throttle and respond very slowly until eventually going down.
Details
By adding a memory limit, docker will kill the container when it gets to the limit of memory usage and the docker container will be restarted – as its started up with the
--restart unless-stoppedoption.However, we need to add the logic for cleaning the
server.pidif exists when starting the server given that when the docker container starts itself after being killed it runs into an error when starting the server as theserver.pidalready exists: