Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commenting erb files #44

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Jul 11, 2018

closes #43 by switching from nerdcommenter to vim-commentary package

<leader>c<space> still works and maps to vim-commentary key mappings.

@ssuttner
Copy link
Member

@grzuy thanks!

@brauliomartinezlm
Copy link
Member

@grzuy I'm not sure this is working as expected. If I try to comment this block:

  <div id="add-credential">
    <%= link_to "Add credential", user_credentials_path(current_user), method: :post, remote: true, class: "mdc-button" %>
  </div>

I end up with this:

  <%#<div id="add-credential">%>
    <%#<%= link_to "Add credential", user_credentials_path(current_user), method: :post, remote: true, class: "mdc-button" %>%>
  <%#</div>%>

Which prints %> in the view.
Not blaming your changes, just new commenter plugin 😄

@grzuy
Copy link
Contributor Author

grzuy commented Jul 11, 2018

I am getting this, which is a bit different from what you're getting.

  <%# <div id="add-credential"> %>
  <%#   <%= link_to "Add credential", user_credentials_path(current_user), method: :post, remote: true, class: "mdc-button" %1> %>
  <%# </div> %>

Are you sure you are testing with this cedarvim branch active, git submodule update, and close/re-open vim buffers after the update?

@brauliomartinezlm
Copy link
Member

For some reason, I ended up with the old nerdcommenter in my dirty. You're right about what's the current output. Merging.

@brauliomartinezlm brauliomartinezlm merged commit c857bc9 into cedarcode:master Jul 11, 2018
@grzuy grzuy deleted the fix_erb_comments branch July 11, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment'ing in .erb files doesn't work as expected
3 participants