Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst #351

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Update index.rst #351

merged 1 commit into from
Jul 29, 2020

Conversation

rchurt
Copy link
Contributor

@rchurt rchurt commented Jul 28, 2020

I think it would be worth adding a clarification about Perl (and other language) modules vs. the environment modules described here, because the use of the term "modules" for both can be confusing to new users.

Also fixed some typos and formatting.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #351 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   99.22%   98.97%   -0.25%     
==========================================
  Files           2        2              
  Lines        3232     3232              
==========================================
- Hits         3207     3199       -8     
- Misses         25       33       +8     
Impacted Files Coverage Δ
lib/envmodules.c 95.12% <0.00%> (-4.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3bb34d...437ad6c. Read the comment docs.

I think it would be worth adding a clarification about Perl (and other
language) modules vs. the environment modules described here, because
the use of the term "modules" for both can be confusing to new users.

Also fixed some typos and formatting.
@xdelaruelle
Copy link
Member

Thanks for this contribution. I have reworded a little bit the disclaimer and put it in an rst note element.

@xdelaruelle xdelaruelle merged commit 265b41f into cea-hpc:master Jul 29, 2020
@rchurt rchurt deleted the patch-1 branch July 29, 2020 15:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants