Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init/bash_completion.in: add 'ml' command support #323

Merged
merged 2 commits into from
Mar 14, 2020
Merged

init/bash_completion.in: add 'ml' command support #323

merged 2 commits into from
Mar 14, 2020

Conversation

adrien-cotte
Copy link
Contributor

Hello,

Module 4 is a really good surprise, but I was disappointed to see that "ml" command had no bash completion.
All these fields are covered:

  • every "module" options and commands;
  • every "module load" options;
  • every "module list" options;
  • every loaded module with "-" suffix (ex: "-gcc" if "gcc" module is loaded).

Hope it helps!
Adrien

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #323 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files           2        2           
  Lines        2959     2959           
=======================================
  Hits         2940     2940           
  Misses         19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0388ff...cba4d9b. Read the comment docs.

@xdelaruelle
Copy link
Member

Thanks for this contribution. Bash users will deeply appreciate it.

I have just added one change : not defining the ml completion if ml command is not defined (in case ml option has been disabled).

@xdelaruelle xdelaruelle merged commit 05451a8 into cea-hpc:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants