Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) add support for aes-256-gcm algo for JWE #44

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

vinayakhulawale
Copy link

@vinayakhulawale vinayakhulawale commented Nov 16, 2020

This PR adds support for aes256gcm encryption algo for content encryption.

Also replaces uses for resty.aes with functions from lua-resty-openssl as former one will not be updated anymore to add new algos.

We can also replace evp.lua in future PRs with functions from lua-resty-openssl

cc: @cdbattags

@vinayakhulawale
Copy link
Author

@cdbattags - can you please review this PR ?

@cdbattags
Copy link
Owner

Hi @vinayakhulawale! Haven't forgotten about this. Tests look great. Should have this merged by tomorrow morning.

@vinayakhulawale
Copy link
Author

@cdbattags - ping :)

Copy link
Owner

@cdbattags cdbattags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fantastic work!

@cdbattags cdbattags merged commit 0b9a6ea into cdbattags:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants