-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used labels and service while calling metrics-rs macros #234
Merged
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
4ae7934
Added mock counter with node descriptor as metric key
Sanskar95 15e1389
Added gauge to get the number of messages handled at one node
Sanskar95 5af93ac
removed unused code and libraries
Sanskar95 12fab89
some refactorings
Sanskar95 456708b
some refactorings
Sanskar95 7c1316f
Added perf evets library where hardware metrics are getting exported …
Sanskar95 72f627e
added message per second metric exposed over a prometheus gauge
Sanskar95 78f0c5f
added more hardware metrics and some code refactor
Sanskar95 79be73e
using tota events method to get batch events
Sanskar95 5b290ab
added all the hardware metrics , configurable through OpearatorConf
Sanskar95 94477bc
Added hardware_counter feature flag and removed old metric structs fr…
Sanskar95 98b9a53
Added node run time event: inbound throughput through the meter
Sanskar95 819a9be
Variable name refactor
Sanskar95 afc8898
Added epoch counter node run time metric
Sanskar95 60b6595
Added watermark_counter
Sanskar95 4ad0428
added mock metrics to source node ,like error counter
Sanskar95 3a7cb4f
added mock metrics to source node ,like error counter
Sanskar95 233d196
Added description in source node so as to name the metrics
Sanskar95 88025fc
Counting the messages in Poll ready in process fn of SourceNode
Sanskar95 bc4bed7
Adding custom gauges in counter through operatorContext
Sanskar95 baa8068
Added metrics feature flags at required places
Sanskar95 118578d
Changed the join method to concatenate two string references
Sanskar95 a26c190
Changed to format from join method to concatenate string references
Sanskar95 a01c3f0
Code Cleanup
Sanskar95 b6a9899
changed to counter from gauge for watermark and epoch counter
Sanskar95 abb3e5b
Added [cfg(not(test))] for hardware counters
Sanskar95 5d5d9ed
added description about feature flags
Sanskar95 5c80ea9
syncing kafka_source with master to avoid conflicts
Sanskar95 677c52c
Added [cfg(feature="metrics")] to rest of the places
Sanskar95 ba1cd6a
Changed struct naming scheme and some refactor
Sanskar95 01b26b3
Code Refactor
Sanskar95 93b97bc
register_hardware_metric_gauges method name change
Sanskar95 b8ee3e1
Refactor variable names
Sanskar95 eb5ccc6
Resolving merge conflicts due to upstream changes
Sanskar95 48599cf
Enabled target os linux for perf event
Sanskar95 93887f9
added #[cfg(all(feature = "hardware_counters", target_os = "linux"))]
Sanskar95 39a5de8
Fix
Sanskar95 5aabaff
PR review changes and added a software metric batch_execution time
Sanskar95 87118f8
Code formatting
Sanskar95 e19336d
Improving in code docs
Sanskar95 c27dcf8
Changed to increment_counter! macro from counter! where the value is …
Sanskar95 5d6f23a
PR review comments changes
Sanskar95 5dbbd2e
Removed counter fields from struct
Sanskar95 be4ea1f
Used labels and service while calling metrics-rs macros
Sanskar95 ae63104
Resolved merge conflicts from upstream master
Sanskar95 5b383ed
Checking in the updated CI file
Sanskar95 7fa1843
Code Refactor
Sanskar95 3a11d0c
removed comments
Sanskar95 4d9f22e
Shifted group creation from constructor to handle_message
Sanskar95 114e253
removed redundant code and some refactor
Sanskar95 c09681b
removed var type from tuples while creating counters
Sanskar95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registration should happen in Node::new().
I think we can remove the HardwareMetricGroup now that we operate locally. Also, a lot of code can be removed.
We don't need to reset the group.
for iterators, no need to store the iterator in a variable.
The code below has not been verified to compile but should be possible to write it like that.