Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Firebase Emulators support #28

Merged
merged 17 commits into from
Sep 19, 2023
Merged

Feature: Firebase Emulators support #28

merged 17 commits into from
Sep 19, 2023

Conversation

Goku-kun
Copy link
Contributor

@Goku-kun Goku-kun commented Sep 19, 2023

Hey, @ccrsxx!

Re-opening a new PR to close #26 and #22 . I'm not sure if it's caught up to all the commits in the previous PRs. Can you take a look at the changes that you've made and confirm if they're? Pretty sure they aren't because I don't see the work about the environment variables switch that we talked about in the commit history.

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
twitter-clone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 11:57am

@vercel
Copy link

vercel bot commented Sep 19, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @ccrsxx on Vercel.

@ccrsxx first needs to authorize it.

@ccrsxx
Copy link
Owner

ccrsxx commented Sep 19, 2023

Yeah, I have to push my previous commits back. For some reason, the previous pr got screwed even tho I push the latest commits I made.

I got a permission issue, then I did the push -f, I already made sure that I was not behind any commits before I did it, but yeah it removed the entire commits on the PR lol. I'd never use -f flag again when pushing lol.

@Goku-kun
Copy link
Contributor Author

Goku-kun commented Sep 19, 2023

Now I feel like trying out the -f flag honestly. 🤣

Edit: Also I noticed you're a Re:zero fan. I was a Emilia fan too back in 2017, I guess. Dropped Re:zero manga in 2018 and haven't had the time to go back to it. How is it?

@ccrsxx
Copy link
Owner

ccrsxx commented Sep 19, 2023

Now I feel like trying out the -f flag honestly. 🤣

Edit: Also I noticed you're a Re:zero fan. I was a Emilia fan too back in 2017, I guess. Dropped Re:zero manga in 2018 and haven't had the time to go back to it. How is it?

It's Arc 8 now in web novel, basically Season 6 in anime. Don't even bother reading the manga, as it's still behind the Anime lol even now, it's not even finished covering Arc 4 / Season 2 of the Anime, which was released in 2020.

If you dropped the manga back in 2018, then you already watched season 1 right? the story gets better in Season 2, here you'll get some info about the world-building, new characters, some good character development, and obviously more suffering for Subaru 😄 .

If you plan to continue on the series after watching season 2, I suggest you read Light novel starting from volume 15.

As for future seasons, the story continues to be good. Can't explain it in detail because the story is very long lol.

@ccrsxx ccrsxx self-requested a review September 19, 2023 12:15
Copy link
Owner

@ccrsxx ccrsxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccrsxx ccrsxx self-assigned this Sep 19, 2023
@ccrsxx ccrsxx merged commit 326dd1f into ccrsxx:main Sep 19, 2023
4 checks passed
@ccrsxx
Copy link
Owner

ccrsxx commented Sep 19, 2023

Once again, @Goku-kun thanks for the PR. Sorry, it took me so long to close it lol.

@Goku-kun
Copy link
Contributor Author

Amazing work @ccrsxx! Thanks for all the help! It was a pleasure.

Yeah, I've read through the introduction of all witches the first time. I believe I stopped after that. Gonna read the web novel then! Haha. Thanks for the insight. Also, Oshi no Ko Ruby? LOLOLOL. I think Akane is the best girl but I digress. 🤣

@ccrsxx
Copy link
Owner

ccrsxx commented Sep 20, 2023

@Goku-kun Do you read the manga? Ruby currently plays a huge role in the story. Not to mention she's kinda winning on the ship LOL. She's my favorite character in the manga, Akane was previously my favorite, but Ruby takes her place.

@Goku-kun
Copy link
Contributor Author

Goku-kun commented Sep 20, 2023

@ccrsxx Ah, no. The adaptation is so fantastic that I don't want to read the manga. Akane and Arima Kana's characters have been introduced with a certain depth in the anime so I like the characters. Meanwhile, we'll learn more about Ruby in the later seasons like you said. So, for now, I think Akane is the best girl for me.

On the other hand, I couldn't control myself and read through to the current chapter of JJK in the past. The wait for the anime adaptation was too long. The anime will take 4-5 years to catch up to the current Gojo fight but sheesh.... The manga didn't disappoint at all. Same for One Piece. I read till the end of Wano arc in August 2022 but the anime still hasn't ended the arc after more than a year. For Oshi no Ko, I'm gonna wait. There's a new manga that started recently on Shounen Jump called Kagurabachi. If you're into darker themes, I think you'll enjoy this one so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants