Change header export settings in FMDB and FMDB-IOS targets #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a copy headers build phase to the FMDB-IOS target, which includes the same Public headers as the FMDB target. Also makes FMDatabasePool.h a Private (rather than a Project) header in both FMDB and FMDB-IOS, so if an application imports FMDatabase.h, then FMDatabase will be able to find FMDatabasePool.h. This makes it easier to incorporate FMDB-IOS into an iOS application project. FMDB can be included in the app's project as a subproject, and the app target can depend on and link against FMDB-IOS, and find the FMDB headers in a natural place: $(BUILT_PRODUCTS_DIR)/usr/local/include.
Adds the FMDB directory to the header folder paths so FMDB headers can be imported like headers from a "normal" library: import <FMDB/FMDatabase.h> instead of import <FMDatabase.h>
|
@ccgus would you be interested in accepting a pull request like this if it were rebased on master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes cause the FMDB-IOS library target to export headers so projects that depend on FMDB-IOS can find those headers in a natural place under $(BUILT_PRODUCTS_DIR)/usr/local/include.
The second commit updates the header export paths of both FMDB and FMDB-IOS so that headers can be imported like:
instead of