Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General QOL Improvements #20

Merged
merged 6 commits into from
Nov 19, 2022
Merged

General QOL Improvements #20

merged 6 commits into from
Nov 19, 2022

Conversation

FerrahWolfeh
Copy link
Contributor

It's a a small batch of stuff that might be useful to contribute

  • Comply with XDG-guidelines - place cache files in a standard dir for all operating systems or fallback to ./data
  • Changed some icons to better represent what is happening in player view
  • Don't needlessly allocate a HashSet while reading the db file, just downright use the collected vec as a whole

ccgauche
ccgauche reviewed Nov 19, 2022
View reviewed changes
Copy link
Owner

@ccgauche ccgauche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes just fix the typo and I'll merge

src/database/reader.rs Outdated Show resolved Hide resolved
@ccgauche ccgauche merged commit 5408983 into ccgauche:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccgauche ccgauche ccgauche left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FerrahWolfeh @ccgauche