Fix & Refactor UI/UX Page [Settings]

- [+] fix(settings.tsx): fix conditional rendering of ListItem based on clientConfig.isApp - [+] refactor(settings.tsx): improve readability of conditional rendering code
cccccennnn · Nov 27, 2023 · dda40e2 · dda40e2
1 parent 7df868e
commit dda40e2
Showing 1 changed file with 20 additions and 15 deletions.
diff --git a/app/components/settings.tsx b/app/components/settings.tsx
@@ -914,21 +914,26 @@ export function Settings() {
 
  {!accessStore.hideUserApiKey && (
  <>
- <ListItem
- title={Locale.Settings.Access.CustomEndpoint.Title}
- subTitle={Locale.Settings.Access.CustomEndpoint.SubTitle}
- >
- <input
- type="checkbox"
- checked={accessStore.useCustomConfig}
- onChange={(e) =>
- accessStore.update(
- (access) =>
- (access.useCustomConfig = e.currentTarget.checked),
- )
- }
- ></input>
- </ListItem>
+ {
+ // Conditionally render the following ListItem based on clientConfig.isApp
+ !clientConfig?.isApp && ( // only show if isApp is false
+ <ListItem
+ title={Locale.Settings.Access.CustomEndpoint.Title}
+ subTitle={Locale.Settings.Access.CustomEndpoint.SubTitle}
+ >
+ <input
+ type="checkbox"
+ checked={accessStore.useCustomConfig}
+ onChange={(e) =>
+ accessStore.update(
+ (access) =>
+ (access.useCustomConfig = e.currentTarget.checked),
+ )
+ }
+ ></input>
+ </ListItem>
+ )
+ }
  {accessStore.useCustomConfig && (
  <>
  <ListItem