Accept and ignore 2 parameters passed by shadowsocks-android in shadowsocks plugin mode. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wsocks plugin mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my previous pull request that allowed parameter parsing in shadowsocks mode, compiling latest Cloak-Android gave a non-working binary when used with shadowsocks-android.
In case of VPN mode and fast-open, shadowsocks-android intentionally passes up to 2 extra parameters (-V and --fast-open) to the SIP003 plugin. Since golang flag does not ignore unknown flags, it causes the plugin to start and fail immediately.
This pull request lets cloak accept and ignore those 2 parameters safely in shadowsocks mode.