Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jedis to 3.7.0 #580

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Conversation

mayman
Copy link
Contributor

@mayman mayman commented Sep 8, 2021

Should address #360

@mayman
Copy link
Contributor Author

mayman commented Sep 20, 2021

@kubukoz would you be able to have a look at this please?

The upgrade to Jedis 3.7.0 allows the usage of SSL for redis, which is missing from the current implementation of jedis

@kubukoz
Copy link
Collaborator

kubukoz commented Sep 21, 2021

some compilation failures on 2.12 😅

@mayman
Copy link
Contributor Author

mayman commented Sep 21, 2021

@kubukoz looks like I was missing some type info 🤦, I made sure to run the +test this time!

@kubukoz kubukoz merged commit 5215c4e into cb372:master Sep 21, 2021
@kubukoz
Copy link
Collaborator

kubukoz commented Sep 21, 2021

Thanks @mayman :)

A snapshot should be released automatically to Sonatype in this job: https://github.com/cb372/scalacache/runs/3665273459?check_suite_focus=true
but I think we'll have a milestone release once we fix #522 (feel free to give it a shot if you want - info in comments on that issue). I think the current milestone is less broken than the main branch so would like to avoid milestoning it.

cc @lewisjkl

@mayman mayman deleted the fix/upgrade_jedis_to_3_7 branch September 23, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants