Support polymorphic keys #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2021
lewisjkl
reviewed
Nov 7, 2021
| @@ -65,17 +60,17 @@ object CaffeineCache { | |||
|
|
|||
| /** Create a new Caffeine cache. | |||
| */ | |||
| def apply[F[_]: Sync: Clock, V](implicit config: CacheConfig): F[CaffeineCache[F, V]] = | |||
| Sync[F].delay(Caffeine.newBuilder().build[String, Entry[V]]()).map(apply(_)) | |||
| def apply[F[_]: Sync: Clock, K <: AnyRef, V]: F[CaffeineCache[F, K, V]] = | |||
There was a problem hiding this comment.
It looks like Caffeine requires the K and V to both extend Object (from Java). This wasn't a problem in the past because we were always using String keys. Weirdly, this also only seems to be an issue on Scala 2.12 as it compiles fine for 2.13 and 3. I had to add <: AnyRef just for 2.12, but I am not really sure of an alternative. @kubukoz Do you happen to have any thoughts on this?
There was a problem hiding this comment.
Added an issue #603 to discuss this further. Merging this PR so we can continue on with other things in the meantime.
|
Thanks again @ronnnnnnnnnnnnn for putting this together and sorry it took so long to get around to merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With regard to standardizing the key serialization by making it part of AbstractCache - didn't think it was really necessary so preferred to keep it cleaner and more consistent with value serialization which is left up to the various implementations. I did make some changes to the codec library to allow for simple usage by implementations also for keys, and added such usage to the Redis implementation.
However, If you think it might still be better to standardize it some more, maybe I can add another layer for that inheriting from AbstractCache or something.
Anyway, I hope this is alright. Let me know what you think.