Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auto register runner #46

Merged
merged 19 commits into from
Mar 29, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update docker runner example
  • Loading branch information
npalm committed Mar 29, 2019
commit 56e9f9bd0167cde8b4a76f9d59e407285cc8307e
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
config-terraform.sh

*.out
example/*.secrets*.tfvars
*.secrets*.tfvars
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http:https://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http:https://semver.org/).

## [Unreleased]
- Changed: The runner will register itself based on the registration token. No need to preregister the runner before running terraform. See the [README](README.md) for more details.

## [2.3.0] - 2019-03-27
- Bugfix: Added a profile for the docker machine runners. #41
Expand Down
2 changes: 0 additions & 2 deletions examples/runner-default/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ module "vpc" {

enable_nat_gateway = true
single_nat_gateway = true

enable_s3_endpoint = true

tags = {
Expand All @@ -33,7 +32,6 @@ module "runner" {

runners_name = "${var.runner_name}"
runners_gitlab_url = "${var.gitlab_url}"
runners_name = "${var.runner_name}"

gitlab_runner_registration_config = {
registration_token = "${var.registration_token}"
Expand Down
1 change: 0 additions & 1 deletion examples/runner-default/terraform.tfvars

This file was deleted.