Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting gitlab-runner instance egress rules #257

Merged
merged 1 commit into from
Oct 8, 2020
Merged

feat: allow setting gitlab-runner instance egress rules #257

merged 1 commit into from
Oct 8, 2020

Conversation

mhulscher
Copy link
Contributor

@mhulscher mhulscher commented Oct 5, 2020

Description

Currently, the module allows all egress traffic from the gitlab-runner instance. From a security point of view, I might want to limit the egress network connectivity from the gitlab-runner instance. This PR introduces a new variable called gitlab_runner_egress_rules that allows the user of this module to configure additional egress rules.

Migrations required

NO, however the new default egress rule for the gitlab-runner now also allows egress traffic to all IPv6 address.

Documentation

✔️

Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhulscher thanks

@npalm npalm merged commit fc7e169 into cattle-ops:develop Oct 8, 2020
npalm pushed a commit that referenced this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants