Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use runners.autoscaling instead of OffPeakPeriods #240

Closed
kayman-mk opened this issue Jul 20, 2020 · 3 comments
Closed

Use runners.autoscaling instead of OffPeakPeriods #240

kayman-mk opened this issue Jul 20, 2020 · 3 comments
Assignees
@npalm
Labels
enhancement 🆕 New feature or request

Comments

@kayman-mk
Copy link
Collaborator

I received a warning that the Off Peak time mode shouldn't be used any longer (is deprecated) and should be replaced by [[runner.machine.autoscaling]]

[runners.machine]
OffPeakPeriods = [ 
  "* * 0-8,18-23 * * mon-fri *",
  "* * * * * sat,sun *" ]
@kayman-mk kayman-mk changed the title Use runners.autoscaling Use runners.autoscaling instead of OffPeakPeriods Jul 20, 2020
@npalm
Copy link
Collaborator

npalm commented Jul 20, 2020

@kayman-mk thanks for creating the issue.

@npalm npalm added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 20, 2020
@npalm
Copy link
Collaborator

npalm commented Jul 20, 2020

Reference to docs: https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersmachine-section

npalm added a commit that referenced this issue Jul 22, 2020
@npalm
#240 - Fix for depcrecated off peak settings
f6f5dad
@npalm npalm mentioned this issue Jul 22, 2020
Merged
@npalm npalm self-assigned this Jul 23, 2020
@npalm npalm added enhancement 🆕 New feature or request and removed good first issue Good for newcomers help wanted Extra attention is needed labels Jul 23, 2020
@npalm
Copy link
Collaborator

npalm commented Jul 23, 2020

@kayman-mk I have create an implementation, needs to finish a bit of docs. Please feel free to have a look at PR #242

npalm added a commit that referenced this issue Aug 2, 2020
@npalm
fix for depcrecated off peak settings (#242)
834d573 
* #240 - Fix for depcrecated off peak settings

* Update docs

* Add vscode suggestions
@npalm npalm closed this as completed Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npalm npalm

Labels
enhancement 🆕 New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@npalm @kayman-mk