fix(uptime): filter out singular "user" string in sed expression #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryan-hoang
changed the title
Previously, on machines where the logged-in user count is 1, the `sed` expression to filter out "... X users, ..." doesn't filter out "... X user, ...", leading to something like ``` 1h 05, 1 user, load average: 0.05, 0.72, 1.62m ``` being displayed in the module. When the user count is greater than 1 (e.g., after `ssh localhost`), the `uptime` module displays ``` 1h 05m ``` as expected. The Stack Overflow answer the `sed` expression is based on [^1][^2] doesn't seem to consider the case when the user count is 1. With this patch, the `uptime` module display correctly when the user count is 1. [^1]: https://stackoverflow.com/a/28353785 [^2]: #163
bryan-hoang
force-pushed
the
bugfix/uptime-module-single-user
branch
from
2bc5c58
to
45e74df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on machines where the logged-in user count is 1, the
sedexpression to filter out "... X users, ..." doesn't filter out "... X user, ...", leading to something likebeing displayed in the module. When the user count is greater than 1 (e.g., after
ssh localhost), theuptimemodule displaysas expected.
With this patch, the module displays correctly when the user count is 1.
The Stack Overflow answer the
sedexpression is based on 12 doesn't seem to consider the case when the user count is 1.Footnotes
https://stackoverflow.com/a/28353785 ↩
https://github.com/catppuccin/tmux/pull/163 ↩