Refactor tolerance settings for BEIR dense vector regressions #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lintool
commented
Jun 25, 2024
lintool
commented
- tweak docs for flat indexes.
- refactor tolerance values for HNSW indexes, calibrate wrt flat index scores.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2538 +/- ##
=========================================
Coverage 67.18% 67.18%
Complexity 1481 1481
=========================================
Files 219 219
Lines 12645 12645
Branches 1528 1528
=========================================
Hits 8495 8495
Misses 3624 3624
Partials 526 526 ☔ View full report in Codecov by Sentry. |
|
hey @tteofili @MXueguang - this is ready for review... it's a big PR, so just isolating to BEIR for now. Will circle back and work on MS MARCO next. |
MXueguang
approved these changes
Jun 26, 2024
lintool
added a commit
that referenced
this pull request
Jul 8, 2024
) Continuation of #2538 - refactor tolerance values for HNSW indexes, calibrate wrt flat index scores.
Panizghi
pushed a commit
to Panizghi/anserini
that referenced
this pull request
Jul 9, 2024
…ini#2538) + tweak docs for flat indexes. + refactor tolerance values for HNSW indexes, calibrate wrt flat index scores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.