Expose API checks as a CLI #1061
Conversation
| @@ -325,7 +325,7 @@ class ZiplinePluginTest { | |||
| val result = createRunner(projectDir, "clean", taskName).buildAndFail() | |||
| assertThat(result.output).contains( | |||
| """ | |||
| |Zipline API file is incomplete. Run :ziplineApiDump to update it. | |||
| |Zipline API file is incomplete. Run zipline-api-dump to update it. | |||
There was a problem hiding this comment.
Not sure how I feel about this. The CLI’s instructions recommend the CLI command to re-run, but this could be confusing for Gradle users since it wants :ziplineApiDump and not zipline-api-dump.
There was a problem hiding this comment.
I pass in the command to report in failure messages so that I can vary it between raw CLI usage and Gradle usage.
There was a problem hiding this comment.
Done. Good idea.
| } | ||
|
|
||
| @TaskAction | ||
| fun task() { |
There was a problem hiding this comment.
Much of this plumbing stolen from Redwood
|
|
||
| private val classpath by option("--class-path") | ||
| .convert { it.split(File.pathSeparator).map(::File) } | ||
| .required() |
There was a problem hiding this comment.
The Clikt API is so so nice I love it. Thank you, @ajalt!
There was a problem hiding this comment.
Thanks for the kind words!
If you didn't know about the built-in split, you could use it to make this even a little simpler:
val classpath: List<File> by option("--class-path")
.file().split(File.pathSeparator).required()Don't depend on the zipline-api-validator code in the Gradle runtime; instead fork a process and call this CLI. Also migrate from Picocli to Clikt.
6f79fef
to
a59ef55
Compare
Don't depend on the zipline-api-validator code in the Gradle runtime; instead fork a process and call this CLI.
Also migrate from Picocli to Clikt.