Fix API checks for Android builds #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54313f6
to
87e57d5
Compare
87e57d5
to
0dbae82
Compare
JakeWharton
approved these changes
Jun 24, 2023
| registerZiplineApiTask(target, kotlinCompile, ZiplineApiValidationTask.Mode.Check) | ||
| registerZiplineApiTask(target, kotlinCompile, ZiplineApiValidationTask.Mode.Dump) | ||
| } | ||
| if ("Test" in kotlinCompile.name) return@withType |
There was a problem hiding this comment.
I think we can get at the main compilation task through
kotlinExtension.targets.all { target -> .. }but that can be a follow-up. At the very least it reduces the risk of name-based task logic. Someone could, in theory, have "Test" in their target name.
Co-authored-by: Jake Wharton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.