Fix collision in serviceTypeCache keys #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were selecting cache keys at build-time, which resulted in multiple flows using the same serializer instances, despite having different runtime types. This changes key construction to happen at runtime instead. Closes: #1039
swankjesse
commented
Jun 11, 2023
| @@ -241,4 +244,28 @@ internal class FlowTest { | |||
| assertEquals(setOf(), endpointA.serviceNames) | |||
| assertEquals(setOf(), endpointB.serviceNames) | |||
| } | |||
|
|
|||
| /** https://github.com/cashapp/zipline/issues/1039 */ | |||
There was a problem hiding this comment.
This test crashed on the old code attempting to use an Int serializer on a string.
JakeWharton
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were selecting cache keys at build-time, which resulted in multiple flows using the same serializer instances, despite having different runtime types.
This changes key construction to happen at runtime instead.
Closes: #1039