Add CI build using GitHub Actions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickEntin
commented
Mar 10, 2021
Comment on lines
+24
to
+29
| - name: Prepare iOS 13 Simulator | ||
| run: | | ||
| sudo mkdir -p /Library/Developer/CoreSimulator/Profiles/Runtimes | ||
| sudo ln -s /Applications/Xcode_11.7.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/Runtimes/iOS.simruntime /Library/Developer/CoreSimulator/Profiles/Runtimes/iOS\ 13.7.simruntime | ||
| xcrun simctl list runtimes | ||
| if: matrix.platform == 'iOS_13' |
There was a problem hiding this comment.
Adapted from this comment.
brianpartridge
approved these changes
Mar 10, 2021
| @@ -65,7 +65,7 @@ Note that the demo app uses an email-based bug reporter, so it will not be able | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| * Xcode 11.0 or later | |||
| * Xcode 12.0 or later | |||
There was a problem hiding this comment.
It looks like CI is configured to use Xcode 11. Can we make this consistent?
There was a problem hiding this comment.
The builds should always use Xcode 12.
- name: Select Xcode Version
run: sudo xcode-select --switch /Applications/Xcode_12.2.app/Contents/Developer
The only thing it references Xcode 11 for is to copy the iOS 13 simulator runtime, since Xcode 12 only comes with iOS 14 pre-installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a copy of the config from AardvarkReveal with the relevant names changed and a few minor tweaks to fit the setup in this repo.